Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Override icon with an image URL #639

Merged
merged 4 commits into from
Apr 12, 2022
Merged

Override icon with an image URL #639

merged 4 commits into from
Apr 12, 2022

Conversation

jampez77
Copy link
Contributor

@jampez77 jampez77 commented Apr 5, 2022

added image attribute to override icon with a URL.

@jampez77
Override icon with an image URL
bad5a74 
added image attribute to override icon with a URL.
@jampez77
Fixed parsing error
39fa038 
Removed duplicate ` in HTML for renderImage()
@jampez77
Copy link
Contributor Author

jampez77 commented Apr 5, 2022

Not sure why this is failing, any help would be appreciated.

@kalkih kalkih added the enhancement New feature or request label Apr 11, 2022
@kalkih
Copy link
Owner

kalkih commented Apr 11, 2022

Sorry the build pipeline was broken on the dev branch, it's now fixed, please do a commit --amend and then a push --force, or rebase the dev branch and push.

@jampez77
Moved renderImage
a886d6d 
Moved `renderImage()` to be part of `renderIcon` and prevent unreachable code problem.
@jampez77
Copy link
Contributor Author

Sorry the build pipeline was broken on the dev branch, it's now fixed, please do a commit --amend and then a push --force, or rebase the dev branch and push.

I've tried that and it's still failing but this time with no information, odd

@kalkih
Copy link
Owner

kalkih commented Apr 12, 2022

The build can be found here: https://app.travis-ci.com/github/kalkih/mini-media-player/builds/249275837

Error: /home/travis/build/kalkih/mini-media-player/src/main.ts(296,21): semantic error TS2339: Property 'image' does not exist on type 'MiniMediaPlayerConfiguration'.

You need to add the new config option to the MiniMediaPlayerBaseConfiguration interface.

kalkih
kalkih requested changes Apr 12, 2022
View reviewed changes
README.md Outdated Show resolved Hide resolved
@jampez77
Updating to icon_image
fc6c4cf 
Updated attribute to icon_image and added it to `MiniMediaPlayerBaseConfiguration`
@kalkih
Copy link
Owner

kalkih commented Apr 12, 2022

Great stuff!

@kalkih kalkih merged commit a1890d5 into kalkih:dev Apr 12, 2022
kalkih pushed a commit that referenced this pull request May 1, 2022
@jampez77 @kalkih
Option to override icon with an image (#639)
c493311
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kalkih kalkih kalkih approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jampez77 @kalkih